Skip to content

Fix empty array edge cases in robustfit - #489

Merged
pr0m1th3as merged 4 commits into
gnu-octave:mainfrom
Sonu0305:fix-robustfit-empty
Sep 16, 2026
Merged

pr0m1th3as merged 4 commits into
gnu-octave:mainfrom
Sonu0305:fix-robustfit-empty

Conversation

@Sonu0305

Copy link
Copy Markdown
Contributor

No description provided.

@pr0m1th3as

Copy link
Copy Markdown
Member

Wording matches MATLAB, no need to replicate exact wording in error/warning messages. Remove the %!test block that holds only a comment, give the %!error tests the full message, and start the message in lower case: "robustfit: not enough points to perform robust estimation."

@Sonu0305

Copy link
Copy Markdown
Contributor Author

updated @pr0m1th3as
can you review again, thank you.

@pr0m1th3as

Copy link
Copy Markdown
Member

Looks good. Only write zeros (0, 3) and zeros (0, 1) with spaces in the tests.

@Sonu0305

Copy link
Copy Markdown
Contributor Author

updated @pr0m1th3as

@pr0m1th3as
pr0m1th3as merged commit da12a73 into gnu-octave:main Sep 16, 2026
@Sonu0305
Sonu0305 deleted the fix-robustfit-empty branch September 16, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants